Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Validation check for the bkey #329

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

ing-eoking
Copy link
Collaborator

๐Ÿ”— Related Issue

โŒจ๏ธ What I did

  • query_init์—์„œ bkey validation check ํ•˜๋„๋ก ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค.

Copy link
Contributor

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ ์™„๋ฃŒ

libmemcached/collection.cc Show resolved Hide resolved
libmemcached/collection.cc Show resolved Hide resolved
libmemcached/collection.cc Show resolved Hide resolved
libmemcached/collection.cc Show resolved Hide resolved
libmemcached/collection.cc Show resolved Hide resolved
Copy link
Collaborator Author

@ing-eoking ing-eoking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhpark816
์ˆ˜์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

rc= do_coll_update(ptr, key, key_length,
&query, update_filter, value, value_length,
BOP_UPDATE_OP);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ing-eoking
update_filter๋ผ๋Š” ์šฉ์–ด๊ฐ€ ๊ทธ๋Œ€๋กœ ๋‚จ์•„ ์žˆ๋„ค์š”.
์ €๋ฒˆ์— ์ˆ˜์ •ํ•˜๋ฉด์„œ ๋ˆ„๋ฝ๋œ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

์ฝ”๋“œ์™€ ๋ฌธ์„œ์—์„œ update_filter ๋Œ€์‹ ์— eflag_update๋กœ ๋ณ€๊ฒฝํ•˜๋Š” ์ž‘์—…์„ ๋จผ์ € ์ง„ํ–‰ํ•˜์‹œ์ฃ .
PR ๋ณด๋‚ด์ฃผ์„ธ์š”.

๊ทธ ์ดํ›„์— ๋ณธ PR์„ rebaseํ•ด ์ฃผ๋ฉด ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhpark816
์ˆ˜์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

@jhpark816 jhpark816 merged commit f1b0e1c into naver:develop Dec 24, 2024
1 check passed
@ing-eoking ing-eoking deleted the init branch December 24, 2024 06:34
@jhpark816
Copy link
Contributor

jhpark816 commented Dec 30, 2024

@ing-eoking @namsic

๋ณธ PR์ด merge๋œ ์ดํ›„์— ์•„๋ž˜ ์ปดํŒŒ์ผ ์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒํ•ฉ๋‹ˆ๋‹ค.

libmemcached/collection.cc: In function 'memcached_return_t memcached_bop_ext_piped_insert(memcached_st*, const char*, size_t, size_t, const unsigned char* const*, const size_t*, const unsigned char* const*, const size_t*, const char* const*, const size_t*, memcached_coll_create_attrs_st*, memcached_return_t*, memcached_return_t*)':
libmemcached/collection.cc:5163:3: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   if (rc == MEMCACHED_SUCCESS)

@ing-eoking
Copy link
Collaborator Author

ing-eoking commented Dec 30, 2024

@jhpark816

ํ˜น์‹œ ์ €ํฌ์ชฝ ์žฅ๋น„์—์„œ ๋ฐœ์ƒํ–ˆ๋‚˜์š”?

์ฝ”๋“œ๋ฅผ ํ™•์ธํ–ˆ์„ ๋•Œ, ๋ฐœ์ƒํ•œ ์˜ค๋ฅ˜๋Š” ํ•ด๋‹น PR๊ณผ ๊ด€๊ณ„์—†์–ด ๋ณด์ž…๋‹ˆ๋‹ค.

@jhpark816
Copy link
Contributor

@ing-eoking
PR์„ ๋ช…์‹œํ•˜์ง€ ์•Š์•˜๊ตฐ์š”. PR ๋งํฌ๋ฅผ ๋„ฃ์–ด ๋‘์—ˆ์Šต๋‹ˆ๋‹ค.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants