Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Modify examples for the btree document #327

Merged
merged 1 commit into from
Jan 2, 2025
Merged

DOC: Modify examples for the btree document #327

merged 1 commit into from
Jan 2, 2025

Conversation

ing-eoking
Copy link
Collaborator

๐Ÿ”— Related Issue

  • jam2in/arcus-works#636

โŒจ๏ธ What I did

  • btree ์•„์ดํ…œ ๊ด€๋ จ API ๋ฌธ์„œ๋ฅผ map, set๊ณผ ์œ ์‚ฌํ•œ ํ˜•์‹์œผ๋กœ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.

@ing-eoking ing-eoking marked this pull request as draft December 17, 2024 01:41
@ing-eoking ing-eoking marked this pull request as ready for review December 17, 2024 03:23
@ing-eoking ing-eoking requested a review from jhpark816 December 17, 2024 03:23
jhpark816
jhpark816 reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ผ๋ถ€ ๋ฆฌ๋ทฐ

docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
@ing-eoking ing-eoking mentioned this pull request Dec 18, 2024
Merged
jhpark816
jhpark816 reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ ์™„๋ฃŒ.

๋‹ค์Œ review ํ•ด์•ผ ํ•  ์ƒํƒœ๊ฐ€ ๋˜๋ฉด, noti ์ฝ”๋ฉ˜ํŠธ๋ฅผ ๋‚จ๊ฒจ์ฃผ์„ธ์š”.

docs/07-btree-API.md Outdated Show resolved Hide resolved
@ing-eoking ing-eoking marked this pull request as draft December 31, 2024 02:27
@ing-eoking ing-eoking force-pushed the btree branch 5 times, most recently from 6d1fc85 to c5ac47d Compare January 2, 2025 01:05
@ing-eoking
Copy link
Collaborator Author

@jhpark816

rebase ๋ฐ ์ „์ฒด ์ˆ˜์ • ์™„๋ฃŒ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

@ing-eoking ing-eoking marked this pull request as ready for review January 2, 2025 01:10
@ing-eoking
Copy link
Collaborator Author

@jhpark816

eflag => new_eflag ๋ณ€๊ฒฝ ๋ถ€๋ถ„๊นŒ์ง€ ๋ชจ๋‘ ์™„๋ฃŒ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

jhpark816
jhpark816 reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ผ๋ถ€ ๋ฆฌ๋ทฐ

docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated
memcached_return_t last_response= memcached_get_last_response_code(memc);
assert(rc == MEMCACHED_SUCCESS);
assert(last_response == MEMCACHED_END || last_response == MEMCACHED_TRIMMED ||
last_response == MEMCACHED_DELETED || last_response == MEMCACHED_DELETED_DROPPED);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEMCACHED_TRIMMED ์‘๋‹ต์ด ์˜ฌ ์ˆ˜ ์žˆ๋Š” ์ง€๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEMCACHED_TRIMMED ์‘๋‹ต์€ ์ •์ƒ์ธ๊ฐ€์š”?

์•ž์„œ ์งˆ๋ฌธํ•œ ๊ฒƒ์ธ๋ฐ, ์ด์— ๋Œ€ํ•œ ๋‹ต๋ณ€์ด ์—†์Šต๋‹ˆ๋‹ค.
๋‹ต๋ณ€ ๋ฐ”๋ž๋‹ˆ๋‹ค.

Copy link
Collaborator Author

@ing-eoking ing-eoking Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹จ์ผ bkey์— ๋Œ€ํ•œ get์€ TRIMMED ์‘๋‹ต์ด ์˜ค์ง€ ์•Š์Šต๋‹ˆ๋‹ค.
๊ทธ๋Ÿฌ๋ฏ€๋กœ ์ด๋ฅผ ๊ฒ€์‚ฌํ•  ํ•„์š” ์—†์Šต๋‹ˆ๋‹ค.

์˜ˆ์‹œ๋ฅผ ๋งŒ๋“œ๋Š” ๊ณผ์ •์—์„œ ์ž˜๋ชป ๋„ฃ์€ ๊ฒƒ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค.
ํ˜„์žฌ๋Š” ๋‹จ์ผ bkey ์กฐํšŒ ์˜ˆ์‹œ๋ฅผ ๋ชจ๋‘ ์ง€์› ์Šต๋‹ˆ๋‹ค.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฒ”์œ„ ๊ฒ€์ƒ‰์—์„œ๋Š” TRIMMED ์‘๋‹ต์ด ๋‚˜์˜ค๋Š”๊ฐ€์š”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ค. TRIMMED ์‘๋‹ต์ด ๋‚˜์˜ต๋‹ˆ๋‹ค.

docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
docs/07-btree-API.md Outdated Show resolved Hide resolved
@ing-eoking
Copy link
Collaborator Author

@jhpark816

์ „์ฒด ์ˆ˜์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

@jhpark816 jhpark816 merged commit e31c51b into naver:develop Jan 2, 2025
1 check passed
@ing-eoking ing-eoking deleted the btree branch January 2, 2025 07:25
@ing-eoking ing-eoking mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpark816 jhpark816 jhpark816 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ing-eoking @jhpark816