Add Hashicorp Kv v1 support #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @k0rventen this seems like a great change. Would love to see you wrap it up so we can get it added! |
|
Thx @jathanism , I've added the missing doc in various places and added the tests for the kv1 to the test harness, but I'm unable to launch the tests locally using poetry/invoke (same issue as in #49). Could one of the maintainer approve the review to enable the tests on the CI side ? |
nniehoff
reviewed
Mar 14, 2023
Co-authored-by: nniehoff <github@nickniehoff.net>
|
@nautobot/core please give a review then I'll batch this in with the next release hopefully today |
nautobot_secrets_providers/templates/nautobot_secrets_providers/home.html
Outdated
Show resolved
Hide resolved
…s/home.html Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
glennmatthews
approved these changes
Apr 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support for the kv engine v1 on the Hashicorp provider.
The changes are minimal, as the only thing that changes is the path of the secret, where in v2 a
/datais added compared to v1.By default the version is
v2to retain backwards compatibility. A newkv_versionargument is available in the secrets.I haven't changed the tests yet, but I've tested the functionality locally against a vault with v1 kv engine. This first iter is just to make sure that the initial tests & CI is still working OK with my changes before making changes.