Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strict filtering for ip-addresses #163

Merged
merged 13 commits into from
Sep 7, 2022
Merged

Fix strict filtering for ip-addresses #163

merged 13 commits into from
Sep 7, 2022

Conversation

FragmentedPacket
Copy link
Contributor

@FragmentedPacket FragmentedPacket commented Aug 28, 2022 •
edited
Loading

STRICT_FILTERING config option breaks the ip_address module due to assign_object and assigned_object_id are not valid filters.

Added vminterface and conversion to vminterface_id. This will be backwards compatible.

Fixes #164

@FragmentedPacket FragmentedPacket mentioned this pull request Sep 7, 2022
Closed
@jvanderaa jvanderaa merged commit 999b10d into nautobot:develop Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanderaa jvanderaa jvanderaa approved these changes

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@joewesch joewesch Awaiting requested review from joewesch joewesch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPAddressFilterSet doesn't understand assigned_object nor assigned_object_id
2 participants
@FragmentedPacket @jvanderaa