Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust layer for encoding/decoding parquet files #699

Merged
merged 13 commits into from
Jul 22, 2022
Merged

Conversation

twitu
Copy link
Collaborator

@twitu twitu commented Jul 16, 2022

Pull Request

  • C-bindings for catalog
  • Rust arrow2 style schema defintions
  • Generic traits for reading and writing from and to parquet files
  • Working example for reading and writing to and from parquet files

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested?

Rust catalog has been manually tested. C-bindings have unit tests.

@twitu twitu changed the title Rust port of catalog from the persistence layer (WIP) Rust port of catalog from the persistence layer Jul 16, 2022
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #699 (5240b33) into develop (0e53e0f) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 5240b33 differs from pull request most recent head 22fc719. Consider uploading reports for the commit 22fc719 to get more accurate results

@@             Coverage Diff             @@
##           develop     #699      +/-   ##
===========================================
+ Coverage    90.50%   90.53%   +0.02%     
===========================================
  Files          308      308              
  Lines        25951    25946       -5     
===========================================
+ Hits         23488    23491       +3     
+ Misses        2463     2455       -8     
Impacted Files Coverage Δ
nautilus_trader/common/logging.pyx 93.29% <0.00%> (-0.31%) ⬇️
nautilus_trader/model/events/account.pyx 100.00% <0.00%> (ø)
nautilus_trader/persistence/external/core.py 93.75% <0.00%> (+0.96%) ⬆️
nautilus_trader/persistence/catalog/parquet.py 86.17% <0.00%> (+1.59%) ⬆️
nautilus_trader/common/timer.pyx 99.16% <0.00%> (+3.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e53e0f...22fc719. Read the comment docs.

@twitu twitu changed the title (WIP) Rust port of catalog from the persistence layer Rust port of catalog from the persistence layer Jul 22, 2022
@twitu twitu changed the title Rust port of catalog from the persistence layer Rust port of layer that encodes/decodes parquet files Jul 22, 2022
@twitu twitu changed the title Rust port of layer that encodes/decodes parquet files Rust layer for encoding/decoding parquet files Jul 22, 2022
@cjdsellers cjdsellers merged commit c7a737c into develop Jul 22, 2022
@cjdsellers cjdsellers deleted the rs-schema branch July 22, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants