Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] #75 #76

Merged
merged 1 commit into from
Sep 27, 2018
Merged

[FIX] #75 #76

merged 1 commit into from
Sep 27, 2018

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 27, 2018

  • Updated dev dependencies
  • Reduced number of node versions on travis to match supported nodejs engines
  • Small fixes to timing on client.close() - emitting events didn't return causing NPEs

@aricart
[FIX] #75
5b922f2 
- Updated dev dependencies
- Reduced number of node versions on travis to match supported nodejs engines
- Small fixes to timing on client.close() - emitting events didn't return causing NPEs
@aricart aricart requested a review from kozlovic September 27, 2018 15:52
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 94.148% when pulling 5b922f2 on node-version-constraint into 21c46a7 on master.

kozlovic
kozlovic approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit c7030e2 into master Sep 27, 2018
@aricart aricart deleted the node-version-constraint branch September 27, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aricart @coveralls @kozlovic