Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document feature flags #1246

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Document feature flags #1246

merged 1 commit into from
Apr 9, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Apr 9, 2024

Addresses #1243

As there is no good way in Rust to document feature flags beyond listing them, adding comments to Cargo.toml seems to be the best answer.

The link in the Readme directs to the Cargo.toml from latest release, which should avoid docs drift.

Signed-off-by: Tomasz Pietrek tomasz@nats.io

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit fc61743 into main Apr 9, 2024
11 checks passed
@Jarema Jarema deleted the add-features-docs branch April 9, 2024 11:16
Jarema added a commit that referenced this pull request May 6, 2024
# 0.35.0

## Overview

This release makes tls setup more flexible, leveraging rusls v0.23 and allowing to pick crypto backend:
* ring
* aws-lc-rs
* fips

Some other highlights:
* force reconnect via `force_reconnect` method
* explicit create/update consumer API

Thank you for all your contributions!

## Added
* Add `ToServerAddrs` impl for array/vector of strings by @mmalek in #1231
* Add public constructor for Acker by @AbstractiveNord in #1232
* Add force reconnect by @Jarema in #1240
* Add features check by @Jarema in #1247
* Add stream placement by @Jarema in #1250
* Add consumer action by @Jarema in #1254
* Add support for aws-lc-rs (rustls v0.23.0) by @paolobarbolini in #1222

## Fixed
* Use last header value for JetStream messages by @Jarema in #1239

## Changed
* Wrap inbox prefix in an `Arc` by @thomastaylor312 in #1236
* Document feature flags by @Jarema in #1246
* Don't force flush if write buffer isn't empty by @paolobarbolini in #1241

## New Contributors
* @mmalek made their first contribution in #1231

**Full Changelog**: async-nats/v0.34.0...async-nats/v0.35.0



Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Co-authored-by: Piotr Piotrowski <piotr@synadia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants