Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to suppress dupes on JS deny all for system account #2502

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

Resolves #2500

/cc @nats-io/core

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but note that you had some of this fix in a PR that is in draft status: #2411

Copy link
Contributor

@matthiashanel matthiashanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthiashanel
Copy link
Contributor

LGTM, but note that you had some of this fix in a PR that is in draft status: #2411

@matthiashanel
Copy link
Contributor

pressed wrong button

@derekcollison
Copy link
Member Author

Once green will merge.

@derekcollison derekcollison merged commit d29acb8 into main Sep 9, 2021
@derekcollison derekcollison deleted the issue-2500 branch September 9, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatically inserted LN export/import deny rules for JetStream keep accumulating on LN reconnects
3 participants