[FIXED] - Message cleanup for interest stream and no-ack consumers in clustered mode. #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in clustered mode. We were not properly propagating the ack state and proper cleanup of the stream messages. Signed-off-by: Derek Collison <derek@nats.io>
kozlovic
approved these changes
Sep 8, 2021
| // If we are ack none and mset is interest only we should make sure stream removes interest. | ||
| if ap == AckNone && mset.cfg.Retention != LimitsPolicy { | ||
| if o.node == nil || o.cfg.Direct { | ||
| mset.amch <- seq |
There was a problem hiding this comment.
You used to check for amch != nil, not sure if this was necessary or not, but you don't do that anymore.
There was a problem hiding this comment.
In stream.go we always create when cfg.Retention != LimitsPolicy, and since we capture that condition above in line 2359 it has to be present.
There was a problem hiding this comment.
As long as it is not set to nil (which I just checked it is not), then indeed it is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug when an interest retention stream with noack consumers is in clustered mode.
We were not properly propagating the ack state and proper cleanup of the stream messages.
Signed-off-by: Derek Collison derek@nats.io
Resolves #2488 (Related)
/cc @nats-io/core