[FIXED] JetStream: possible deadlock due to lock inversion #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The locking is jetStream->Server, not the otherway around. There was few places where lock inversion could have caused deadlock. Also, a change made recently to solve a deadlock was causing a race that is demonstrated with TestJetStreamRaceOnRAFTCreate. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Order seem to be jetStream -> jsAccount. In JetStreamUsage() we were doing the opposite. Moved the js.mu.RLock() to encompass the whole getting of statistics from jsa. We could do in 2 phases: get js's RLock to get cluster info (if clustered), then get jsa's RLock for the rest, and set cluster info with what we gathered in the first phase. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locking is jetStream->Server, not the otherway around. There
was few places where lock inversion could have caused deadlock.
Also, a change made recently to solve a deadlock was causing
a race that is demonstrated with TestJetStreamRaceOnRAFTCreate.
Signed-off-by: Ivan Kozlovic ivan@synadia.com