-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate test deps from v2 module #158
Conversation
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
fix: change travis job to use test go.mod file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but would like @kozlovic give an LGTM as well as he does the JWT release.
fix: change travis job to use test go.mod file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I posted also a comment in associated issue that we could make a release of the v1 because the cve issue was fixed in both code base. But I am not super comfortable doing a v1 release..
Agree, maybe it can be done too if we branch out from latest v1 release, apply the fix from (#149) and then tag a v1 release that has the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wallyqs The fix is already in. We would not have to actually branch anything. If we were to update the version in the v1 (root) dir to say 1.3.0, and push a tag v1.3.0 then release, it would be totally possible I think. But again, I am not sure I would want to do that.. |
@kozlovic I see now, thanks for the clarification. |
Currently v2 go.mod depends on the v1 version (which includes a CVE), this transitive dependency makes vulnerability check tools report v2 as including the CVE, even though v1 is only being used for testing purposes. This separates the test dependencies in the go.mod files so that this does not happen.
Fixes #156