[feat] allow revocation of all users or activations #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue for the public key is "*", any JWT issued before the timestamp specified will be considered revoked.
go.mod
Outdated
| @@ -1,6 +1,7 @@ | |||
| module github.com/nats-io/jwt | |||
|
|
|||
| require ( | |||
| github.com/nats-io/jwt/v2 v2.0.0-20201015190852-e11ce317263c | |||
There was a problem hiding this comment.
Good catch the scripts were not fmt or running tests for both versions on local env.
v2/account_claims.go
Outdated
| @@ -238,11 +238,11 @@ func (a *AccountClaims) Revoke(pubKey string) { | |||
| // RevokeAt enters a revocation by public key and timestamp into this account | |||
| // This will revoke all jwt issued for pubKey, prior to timestamp | |||
| // If there is already a revocation for this public key that is newer, it is kept. | |||
| // The value is expected to be a public key or "*" | |||
There was a problem hiding this comment.
maybe add * means all
v2/go.sum
Outdated
| @@ -1,3 +1,4 @@ | |||
| github.com/nats-io/jwt/v2 v2.0.0-20201015190852-e11ce317263c/go.mod h1:vs+ZEjP+XKy8szkBmQwCB7RjYdIlMaPsFPs4VdS4bTQ= | |||
There was a problem hiding this comment.
go mod tidy fixed all that
matthiashanel
approved these changes
Oct 30, 2020
kozlovic
reviewed
Oct 30, 2020
| @@ -39,9 +41,19 @@ func (r RevocationList) ClearRevocation(pubKey string) { | |||
| } | |||
|
|
|||
| // IsRevoked checks if the public key is in the revoked list with a timestamp later than | |||
| // the one passed in. Generally this method is called with time.Now() but other time's can | |||
| // the one passed in. Generally this method is called with an issue time but other time's can | |||
There was a problem hiding this comment.
Sorry, I just merged #113 that was a port of some changes that were made in v2/ but not v1/ but were done in the branch_v1 :-). So you should rebase and see if there are some changes that are no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the ability to revoke users/activations by timestamp. If the value for the public key is "*", any JWT issued before the timestamp specified will be considered revoked.