Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add about modal window #47

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Add about modal window #47

merged 3 commits into from
Jan 25, 2021

Conversation

natlex-to-me
Copy link
Collaborator

No description provided.

@natlex-to-me
Copy link
Collaborator Author

Есть проблема с "прыгающей" кнопкой закрытия окна, которую я так и не смог победить.

"Прыгание" происходит когда кнопка начинает вылезать за рамки модального окна. Прыжок происходит в двух местах.

  1. При открытии окна крестик рисуется сначала в уголке частично, затем полностью.
  2. При закрытии окна крестик появляется где-то справа около границы окна.

(1) прыжок, наверное, происходит из-за изменения CSS свойств на модальном окне. Как вариант решения -- отключение анимации BrowserAnimationsModule и подключение NoopAnimationsModule.

artfulsage
artfulsage suggested changes Jan 24, 2021
View reviewed changes
artfulsage
artfulsage suggested changes Jan 24, 2021
View reviewed changes
@artfulsage artfulsage merged commit b1f93b9 into master Jan 25, 2021
@artfulsage artfulsage linked an issue Jan 25, 2021 that may be closed by this pull request
Кнопка "О проекте" #31
Closed
@artfulsage artfulsage modified the milestone: 25.01.2021 Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artfulsage artfulsage artfulsage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Кнопка "О проекте"
2 participants
@natlex-to-me @artfulsage