#20 Add dummy marker storage service #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artfulsage
suggested changes
Dec 25, 2020
src/src/app/main/components/google-map/google-map.component.html
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| addMarker(evnt: google.maps.MouseEvent) { | ||
| this.markerPositions.push(evnt.latLng); | ||
| const newMarker = <Marker>{ |
There was a problem hiding this comment.
@natlex-to-me буквально на днях в картах поменялись типы, теперь этот тип называется google.maps.MapMouseEvent. Скорее всего, еще стоит обновить пакет
There was a problem hiding this comment.
@artfulsage при обновлении пакета @types/googlemaps@3.43.0 возникает проблема
Namespace 'google.maps' has no exported member 'MouseEvent'.Подробности тут DefinitelyTyped/DefinitelyTyped#50253
artfulsage
previously approved these changes
Dec 28, 2020
c0a3882 to
d2891e0
Compare
artfulsage
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.