Carcas #18
Closed
Carcas #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artfulsage
suggested changes
Dec 7, 2020
There was a problem hiding this comment.
@alexevnaa очень много пустых строк, которые надо убрать :) Часто достаточно одной строки, и хорошо, когда они есть, а в json-файлах их обычно не добавляют вовсе
| @@ -91,6 +95,10 @@ | |||
| "src/assets" | |||
| ], | |||
| "styles": [ | |||
|
|
|||
There was a problem hiding this comment.
@alexevnaa в тестах, думаю, можно не подключать
| @@ -28,6 +28,10 @@ | |||
| "src/assets" | |||
| ], | |||
| "styles": [ | |||
|
|
|||
There was a problem hiding this comment.
@alexevnaa убери, пжста, пустые строки
src/src/app/app.component.css
Outdated
| } | ||
|
|
||
|
|
||
| #grid { |
There was a problem hiding this comment.
@alexevnaa лучше использовать классы вместо идентификаторов и тэгов
src/src/app/main/main.component.ts
Outdated
| }) | ||
| export class MainComponent implements OnInit { | ||
|
|
||
| constructor() { } |
There was a problem hiding this comment.
@alexevnaa пустые конструкторы и обработчики событий не нужны.
artfulsage
added a commit
that referenced
this pull request
Dec 10, 2020
Also - set prettier as default vscode formatter - set some default rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Сделала каркас, импортировала библиотеку Material UI