Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: homepage - "no javascript" warning #596

Closed
dsebastien opened this issue Aug 1, 2018 · 1 comment
Closed

ui: homepage - "no javascript" warning #596

dsebastien opened this issue Aug 1, 2018 · 1 comment
Labels
comp: stark-ui must type: feature
Milestone
10.0.0-beta.2

Comments

@dsebastien
Copy link
Contributor

dsebastien commented Aug 1, 2018 •
edited by christophercr
Loading

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

App just breaks

Expected behavior

Warning when javascript is disabled. We had this in Stark 9.
@dsebastien dsebastien added this to the must milestone Aug 1, 2018
@christophercr christophercr changed the title ui: homepage - no javascript warning ui: homepage - "no javascript" warning Nov 8, 2018
@christophercr christophercr modified the milestones: must, 10.0.0-beta.2 Nov 8, 2018
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Nov 12, 2018
@carlo-nomes
feat(stark-starter): add preloading screens
8cdb987 
Added a loading screen for when Angular is starting up.
Added a warning screen for when JavaScript
is not enabled in the browser.
Added a warning for when the browser is not supported.

ISSUES CLOSED: NationalBankBelgium#840 NationalBankBelgium#596 NationalBankBelgium#597
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Nov 12, 2018
@carlo-nomes
feat(stark-starter): add preloading screens
a6df11b 
Added a loading screen for when Angular is starting up.
Added a warning screen for when JavaScript
is not enabled in the browser.
Added a warning for when the browser is not supported.

ISSUES CLOSED: NationalBankBelgium#840 NationalBankBelgium#596 NationalBankBelgium#597
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Nov 12, 2018
@carlo-nomes
feat(stark-starter): add preloading screens
e4d6172 
Added a loading screen for when Angular is starting up.
Added a warning screen for when JavaScript
is not enabled in the browser.
Added a warning for when the browser is not supported.

ISSUES CLOSED: NationalBankBelgium#840 NationalBankBelgium#596 NationalBankBelgium#597
@carlo-nomes carlo-nomes mentioned this issue Nov 12, 2018
Merged
3 tasks
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Nov 12, 2018
@carlo-nomes
feat(stark-starter): add preloading screens
5351b17 
Added a loading screen for when Angular is starting up.
Added a warning screen for when JavaScript
is not enabled in the browser.
Added a warning for when the browser is not supported.

ISSUES CLOSED: NationalBankBelgium#840 NationalBankBelgium#596 NationalBankBelgium#597
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Nov 12, 2018
@carlo-nomes
feat(stark-starter): add preloading screens
b5a6c9c 
Added a loading screen for when Angular is starting up.
Added a warning screen for when JavaScript
is not enabled in the browser.
Added a warning for when the browser is not supported.

ISSUES CLOSED: NationalBankBelgium#840 NationalBankBelgium#596 NationalBankBelgium#597
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Nov 13, 2018
@carlo-nomes
feat(stark-starter): add preloading screens
4022058 
Added a loading screen for when Angular is starting up.
Added a warning screen for when JavaScript
is not enabled in the browser.
Added a warning for when the browser is not supported.

ISSUES CLOSED: NationalBankBelgium#840 NationalBankBelgium#596 NationalBankBelgium#597
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Nov 13, 2018
@carlo-nomes
feat(stark-starter): add preloading screens
844e0fe 
Added a loading screen for when Angular is starting up.
Added a warning screen for when JavaScript
is not enabled in the browser.
Added a warning for when the browser is not supported.

ISSUES CLOSED: NationalBankBelgium#840 NationalBankBelgium#596 NationalBankBelgium#597
@christophercr
Copy link
Collaborator

Closed in #848

carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Nov 16, 2018
@carlo-nomes
feat(stark-starter): add preloading screens
2fec74e 
Added a loading screen for when Angular is starting up.
Added a warning screen for when JavaScript
is not enabled in the browser.
Added a warning for when the browser is not supported.

ISSUES CLOSED: NationalBankBelgium#840 NationalBankBelgium#596 NationalBankBelgium#597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui must type: feature
Projects
None yet
Milestone
10.0.0-beta.2
Development

No branches or pull requests
3 participants
@dsebastien @christophercr @carlo-nomes