feat(stark-starter): add preloading screens #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsebastien
reviewed
Nov 12, 2018
showcase/src/index.html
Outdated
| <p>You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to | ||
| improve your experience.</p> | ||
| <p>You are using an <strong>outdated</strong> browser. Please | ||
| <a href="http://browsehappy.com" |
There was a problem hiding this comment.
If we keep this, then we should point to the https version instead: https://browsehappy.com/
dsebastien
reviewed
Nov 12, 2018
starter/src/index.html
Outdated
| <div class="content"> | ||
| <h1>Browser not supported</h1> | ||
| <p>You are using an <strong>outdated</strong> browser. Please | ||
| <a href="http://browsehappy.com" |
5351b17 to
b5a6c9c
Compare
|
@christophercr, I updated the PR. |
christophercr
suggested changes
Nov 13, 2018
showcase/src/index.html
Outdated
| <app class="stark-app"> | ||
| <div class="stark-loading stark-preload-ui-page" role="alertdialog" aria-busy="true" aria-live="assertive"> | ||
| <header><i></i></header> | ||
| <divs class="content"> |
There was a problem hiding this comment.
<divs>? I think you meant <div>
| display: block; | ||
| } | ||
|
|
||
| .stark-preload-ui-page h1 { |
There was a problem hiding this comment.
Can we rename the stark-preload-ui-page? I think that "ui-page" is not 100% accurate since it is not a page itself...
| @@ -6,14 +6,16 @@ | |||
| <meta charset="utf-8"> | |||
| <title><%= htmlWebpackPlugin.options.starkAppMetadata.name %></title> | |||
|
|
|||
| <meta name="description" content="{%= htmlWebpackPlugin.options.starkAppMetadata.description %}"> | |||
| <meta name="description" content="<%= htmlWebpackPlugin.options.starkAppMetadata.description %>"> | |||
There was a problem hiding this comment.
Oops, we didn't notice it before.. thanks!
| @@ -0,0 +1,93 @@ | |||
| /* Hide the app / loader / browser warning until it is determined if JS is enabled and the if the browser is compatible */ | |||
There was a problem hiding this comment.
Typo: "and the if the browser..." -> "and if the browser..."
b5a6c9c to
4022058
Compare
christophercr
approved these changes
Nov 13, 2018
Added a loading screen for when Angular is starting up. Added a warning screen for when JavaScript is not enabled in the browser. Added a warning for when the browser is not supported. ISSUES CLOSED: NationalBankBelgium#840 NationalBankBelgium#596 NationalBankBelgium#597
4022058 to
844e0fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #840 #596 #597
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no warning for enabling JavaScript or upgrading the browser and when Angular is loading the only thing shown is
loading...Issue Number: #840 #596 #597
What is the new behavior?
Does this PR introduce a breaking change?
Other information