Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: refactor - replace StarkComponentUtil.isInputEnabled by coerceBooleanProperty from @angular/cdk/coercion #1190

Closed
SuperITMan opened this issue Mar 14, 2019 · 0 comments · Fixed by #1304
Closed

ui: refactor - replace StarkComponentUtil.isInputEnabled by coerceBooleanProperty from @angular/cdk/coercion #1190

SuperITMan opened this issue Mar 14, 2019 · 0 comments · Fixed by #1304
Assignees
@christophercr
Labels
breaking change comp: stark-ui type: refactor
Milestone
10.0.0-beta.8

Comments

@SuperITMan
Copy link
Member

SuperITMan commented Mar 14, 2019 •
edited
Loading

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Refactoring

We should remove our internal StarkComponentUtil.isInputEnabled() method and replace it by coerceBooleanProperty from @angular/cdk/coercion which is doing the same thing.

There is no need to repeat what Angular already proposes.
@SuperITMan SuperITMan added this to the 10.0.0-beta.7 milestone Mar 14, 2019
@SuperITMan SuperITMan mentioned this issue Mar 14, 2019
Merged
3 tasks
@SuperITMan SuperITMan modified the milestones: 10.0.0-beta.8, 10.0.0-rc.0 Apr 29, 2019
@christophercr christophercr self-assigned this May 29, 2019
christophercr added a commit to christophercr/stark that referenced this issue May 29, 2019
@christophercr
refactor(stark-ui): remove 'StarkComponentUtil.isInputEnabled' in fav…
bf380b4 
…or of Angular CDK function 'coerceBooleanProperty'

ISSUES CLOSED: NationalBankBelgium#1190
christophercr added a commit to christophercr/stark that referenced this issue May 29, 2019
@christophercr
refactor(stark-ui): remove 'StarkComponentUtil.isInputEnabled' in fav…
8680148 
…or of Angular CDK function 'coerceBooleanProperty'

ISSUES CLOSED: NationalBankBelgium#1190
@christophercr christophercr mentioned this issue May 29, 2019
Merged
3 tasks
christophercr added a commit to christophercr/stark that referenced this issue Jun 4, 2019
@christophercr
refactor(stark-ui): remove 'StarkComponentUtil.isInputEnabled' in fav…
3889c88 
…or of Angular CDK function 'coerceBooleanProperty'

ISSUES CLOSED: NationalBankBelgium#1190

BREAKING CHANGE: `StarkComponentUtil.isInputEnabled()` function has been removed. To coerce boolean inputs in your components you can use the `coerceBooleanProperty()` function from `@angular/cdk/coercion` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophercr christophercr

Labels
breaking change comp: stark-ui type: refactor
Projects
None yet
Milestone
10.0.0-beta.8
2 participants
@christophercr @SuperITMan