Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(stark-ui): remove 'StarkComponentUtil.isInputEnabled' in favor of Angular CDK function 'coerceBooleanProperty' #1304

Merged
merged 1 commit into from
Jun 4, 2019
Merged

refactor(stark-ui): remove 'StarkComponentUtil.isInputEnabled' in favor of Angular CDK function 'coerceBooleanProperty' #1304

merged 1 commit into from
Jun 4, 2019

Conversation

christophercr
Copy link
Collaborator

@christophercr christophercr commented May 29, 2019 •
edited
Loading

ISSUES CLOSED: #1190

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1190

What is the new behavior?

Now coerceBooleanProperty function from @angular/cdk/coercion is used in stark-ui where needed to check for component boolean inputs .

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@christophercr christophercr added this to the 10.0.0-beta.8 milestone May 29, 2019
@coveralls
Copy link

coveralls commented May 29, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.005%) to 92.85% when pulling 3889c88 on christophercr:feature/coerce-boolean-property into f845398 on NationalBankBelgium:master.

@SuperITMan
Copy link
Member

Since you remove StarkComponentUtil.isInputEnabled, I think you should mark this as a breaking change 😊

carlo-nomes
carlo-nomes approved these changes Jun 4, 2019
View reviewed changes
Copy link
Collaborator

@carlo-nomes carlo-nomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 👍

@christophercr
refactor(stark-ui): remove 'StarkComponentUtil.isInputEnabled' in fav…
3889c88 
…or of Angular CDK function 'coerceBooleanProperty'

ISSUES CLOSED: NationalBankBelgium#1190

BREAKING CHANGE: `StarkComponentUtil.isInputEnabled()` function has been removed. To coerce boolean inputs in your components you can use the `coerceBooleanProperty()` function from `@angular/cdk/coercion` instead.
@christophercr christophercr force-pushed the feature/coerce-boolean-property branch from 8680148 to 3889c88 Compare June 4, 2019 11:24
@christophercr
Copy link
Collaborator Author

I've adapted the commit message to mark this as a breaking change 😉 So I think this can be merged right?

@SuperITMan SuperITMan merged commit 6bb3454 into NationalBankBelgium:master Jun 4, 2019
@christophercr christophercr deleted the feature/coerce-boolean-property branch June 4, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlo-nomes carlo-nomes carlo-nomes approved these changes

@SuperITMan SuperITMan SuperITMan approved these changes

Assignees
No one assigned
Labels
breaking change comp: stark-ui type: enhancement
Projects
None yet
Milestone
10.0.0-beta.8
Development

Successfully merging this pull request may close these issues.

ui: refactor - replace StarkComponentUtil.isInputEnabled by coerceBooleanProperty from @angular/cdk/coercion
4 participants
@christophercr @coveralls @SuperITMan @carlo-nomes