Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to pass 11 params #1

Closed
SwinX opened this issue Sep 2, 2016 · 3 comments
Closed

Unable to pass 11 params #1

SwinX opened this issue Sep 2, 2016 · 3 comments

Comments

@SwinX
Copy link

SwinX commented Sep 2, 2016

On my project I currently use constructors with 11 params. May you please extend the lib so I will be able to pass 11 params?
@edef1c
Copy link
Collaborator

edef1c commented Sep 2, 2016 •
edited
Loading

This should work, the 1-10 param thing is mainly for native constructors (and occasionally a nice micro-optimisation)
Are there native constructors with 11 parameters?

@edef1c
Copy link
Collaborator

edef1c commented Sep 2, 2016

Ah! I just realised ES6 classes behave the same as native constructors, that explains it.

@edef1c edef1c closed this as completed in 4dbdc93 Sep 2, 2016
@edef1c
Copy link
Collaborator

edef1c commented Sep 2, 2016

Published as 1.0.4, enjoy ❤️

edef1c added a commit that referenced this issue Sep 2, 2016
@edef1c
use Reflect.construct if available
d0ffb72 
This should let us handle variable-argument ES6 class constructors with
arbitrary argument count, and should prevent #1 from recurring.
It might be unnecessary to have the 11-20 argument cases now, but they
can stay pending further testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edef1c @SwinX