Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes warning when no icon packs are found #180

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

natemoo-re
Copy link
Owner

Fixes #176

The warning for missing collections was accidentally logged before the local collection was loaded.

The log message has also been improved to include the directory of the local icon source first.

Copy link

changeset-bot bot commented Jan 2, 2024

🦋 Changeset detected

Latest commit: 28d882b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro-icon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 3:14am
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 3:14am

@natemoo-re natemoo-re merged commit 580b5cd into main Jan 2, 2024
4 checks passed
@natemoo-re natemoo-re deleted the fix/warning branch January 2, 2024 18:57
@github-actions github-actions bot mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1] Confusing "No icons detected!" message
2 participants