-
-
Notifications
You must be signed in to change notification settings - Fork 64
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Match v0 name behavior for local icons (#179)
* fix(#178): match v0 name behavior for local icons * chore: add changeset * chore(lint): Prettier fix --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
- Loading branch information
1 parent
580b5cd
commit b55cd5f
Showing
3 changed files
with
27 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
--- | ||
"astro-icon": patch | ||
--- | ||
|
||
**BREAKING**: Requires subdirectory prefixes for local icons. | ||
|
||
This fixes a regression introduced in v1 and matches the previous v0 `name` behavior. | ||
|
||
As an example, the `src/icons/logos/astro.svg` file could previously be referenced by the name `astro`. It should correctly be referenced as `logos/astro`. | ||
|
||
**Before** | ||
|
||
```jsx | ||
<Icon name="astro" /> | ||
``` | ||
|
||
**After** | ||
|
||
```jsx | ||
<Icon name="logos/astro" /> | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b55cd5f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
astroicon – ./
www.astroicon.dev
astroicon-nmoo.vercel.app
astro-icon-www.vercel.app
astroicon-git-main-nmoo.vercel.app
astroicon.dev
b55cd5f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
api-astroicon – ./packages/service
api-astroicon-git-main-nmoo.vercel.app
api.astroicon.dev
api-astroicon-nmoo.vercel.app