-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dep: update libvaxis #69
Conversation
Hmm. Looks like the ubuntu tests failed
Thanks for being thorough! I think this is fine to use a non-tagged version |
Yep. I'll have a look tomorrow. |
@natecraddock The test fails mostly because in the latest version of libvaxis, a lot of the types using |
Feel free to lower that number. I wrote those tests to confirm the cursor would be clamped to the bounds of the text. Not the best tests and I'm not super picky about how you change them |
I had to make some changes in |
Thanks for this! |
Thank you! |
We wanted to update libvaxis on Ghostty but because of this bug in the Zig build system - it didn't work out (both
zf
and Ghostty use libvaxis as a dependency, but there are some changes to dependencies inlibvaxis
itself, zigimg and libxev aren't lazy dependencies anymore. And latest libvaxis collides withzf
's older one). As a workaround for now, updatinglibvaxis
onzf
is the first step. Not many changes were needed, and the TUI works as expected. So, if this isn't a bother, merging would be very helpful. Thank you! I've noticed thatzf
only used tagged libvaxis releases in the past - so it's fine if you don't want to update to a non-tagged version.