Skip to content

Commit

Permalink
Support TDigestType in Presto to Velox Query Plan (#24546)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: prestodb/presto#24546

Differential Revision: D69558489
  • Loading branch information
natashasehgal authored and facebook-github-bot committed Feb 13, 2025
1 parent 8524313 commit 617e097
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions velox/exec/fuzzer/PrestoQueryRunner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -446,16 +446,17 @@ bool PrestoQueryRunner::isConstantExprSupported(
bool PrestoQueryRunner::isSupported(const exec::FunctionSignature& signature) {
// TODO: support queries with these types. Among the types below, hugeint is
// not a native type in Presto, so fuzzer should not use it as the type of
// cast-to or constant literals. Hyperloglog can only be casted from varbinary
// and cannot be used as the type of constant literals. Interval year to month
// can only be casted from NULL and cannot be used as the type of constant
// literals. Json, Ipaddress, Ipprefix, and UUID require special handling,
// because Presto requires literals of these types to be valid, and doesn't
// allow creating HIVE columns of these types.
// cast-to or constant literals. Hyperloglog and Tdigest can only be casted
// from varbinary and cannot be used as the type of constant literals.
// Interval year to month can only be casted from NULL and cannot be used as
// the type of constant literals. Json, Ipaddress, Ipprefix, and UUID require
// special handling, because Presto requires literals of these types to be
// valid, and doesn't allow creating HIVE columns of these types.
return !(
usesTypeName(signature, "interval year to month") ||
usesTypeName(signature, "hugeint") ||
usesTypeName(signature, "hyperloglog") ||
usesTypeName(signature, "tdigest") ||
usesInputTypeName(signature, "ipaddress") ||
usesInputTypeName(signature, "ipprefix") ||
usesInputTypeName(signature, "uuid"));
Expand Down

0 comments on commit 617e097

Please sign in to comment.