Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checkout] Allow on-demand address creation on checkout screen #1272

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

mochacr0
Copy link
Contributor

Summary

This update modifies the checkout flow by enabling the creation of billing and shipping addresses when the user submits the respective address forms, instead of waiting until the "Process to Payment" button is clicked.

create-addresses.mp4

@mochacr0 mochacr0 changed the title Allow on-demand address creation on checkout screen [Checkout] Allow on-demand address creation on checkout screen Nov 15, 2024
@mochacr0 mochacr0 marked this pull request as ready for review November 16, 2024 05:17
@duylv27
Copy link
Contributor

duylv27 commented Nov 18, 2024

Just personal taste, I would recommend to improve the UI.

You can reference to any E-Cormerce website, each component need to be easy to recognize. So you can consider following points for the address form:

  • Add border(with different color from the background color), border radius for the form.
  • Reduce the spacing between elements in the form.

@mochacr0
Copy link
Contributor Author

Just personal taste, I would recommend to improve the UI.

You can reference to any E-Cormerce website, each component need to be easy to recognize. So you can consider following points for the address form:

  • Add border(with different color from the background color), border radius for the form.
  • Reduce the spacing between elements in the form.

@duylv27 Thanks for the suggestion. I’ve applied all the recommended changes except for the input background. I think keeping it as is works better in this case since the background is already white. Can you please take a look at this new form?

image

@duylv27
Copy link
Contributor

duylv27 commented Nov 19, 2024

@duylv27 Thanks for the suggestion. I’ve applied all the recommended changes except for the input background. I think keeping it as is works better in this case since the background is already white. Can you please take a look at this new form?

The background form, I meant the parent <div> of all Address Input.

It's kinda like the section comment on Github Issue. As you see below section have border in gray.
image

If it's ok to you, just add the gray border (with border radius) to group all fields retating to address.

Copy link

Storefront BFF Coverage Report

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@mochacr0
Copy link
Contributor Author

mochacr0 commented Nov 19, 2024

@duylv27 Thanks for the suggestion. I’ve applied all the recommended changes except for the input background. I think keeping it as is works better in this case since the background is already white. Can you please take a look at this new form?

The background form, I meant the parent <div> of all Address Input.

It's kinda like the section comment on Github Issue. As you see below section have border in gray. image

If it's ok to you, just add the gray border (with border radius) to group all fields retating to address.

Hi @duylv27, I’ve made some additional updates. Here’s how it looks right now. Let me know if it’s okay for you.

screencapture-localhost-8087-checkout-51ed4c90-e8c1-49ab-a074-59113ba39487-2024-11-19-15_45_45

Copy link

Copy link

@mochacr0 mochacr0 merged commit 12c9990 into main Nov 19, 2024
8 checks passed
@mochacr0 mochacr0 deleted the precreate-checkout-addresses branch November 19, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants