Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCH_LAB should consolidate its globals into a single structure #32

Closed
jphickey opened this issue Feb 10, 2020 · 0 comments · Fixed by #33 or #36
Closed

SCH_LAB should consolidate its globals into a single structure #32

jphickey opened this issue Feb 10, 2020 · 0 comments · Fixed by #33 or #36
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Other CFE core apps all use a single global structure to keep its runtime state. This is preferable because the structure acts as a "namespace" and keeps the globals separate from those of other apps.

Describe the solution you'd like
Replace individual globals with a single SCH_LAB_Global structure which contains all the global variables as members.

Additional context
This is particularly important on systems where globals go into a "common" section and strange behavior can happen if a name collision occurs.

Requester Info
Joseph Hickey, Vantage Systems, Inc
jphickey added a commit to jphickey/sch_lab that referenced this issue Feb 10, 2020
@jphickey
Fix nasa#32: Consolidate SCH_LAB globals into struct
cd7b8f1 
Creating a single struct for the SCH_LAB globals adds namespace
protection and is consistent with the way other CFE modules do this.
jphickey added a commit to jphickey/sch_lab that referenced this issue Feb 10, 2020
@jphickey
Fix nasa#32: Consolidate SCH_LAB globals into struct
b272c29 
Creating a single struct for the SCH_LAB globals adds namespace
protection and is consistent with the way other CFE modules do this.
jphickey added a commit to jphickey/sch_lab that referenced this issue Feb 11, 2020
@jphickey
Merge nasa#27, nasa#31, nasa#32 into EDS baseline
063bffc 
This reflects general issues/patches to the upstream repository that
need to be resolved for EDS support
@jphickey jphickey mentioned this issue Feb 11, 2020
Merged
jphickey added a commit to jphickey/sch_lab that referenced this issue Mar 2, 2020
@jphickey
Fix nasa#32: Consolidate SCH_LAB globals into struct
c134c0a 
Creating a single struct for the SCH_LAB globals adds namespace
protection and is consistent with the way other CFE modules do this.
astrogeco pushed a commit that referenced this issue Mar 9, 2020
@jphickey @astrogeco
Fix #32: Consolidate SCH_LAB globals into struct
56d14b2 
Creating a single struct for the SCH_LAB globals adds namespace
protection and is consistent with the way other CFE modules do this.
@astrogeco astrogeco mentioned this issue Mar 10, 2020
Merged
@astrogeco astrogeco linked a pull request Mar 10, 2020 that will close this issue
Ic 20200304 #36
Merged
@astrogeco astrogeco added this to the 2.4.0 milestone Oct 1, 2020
@astrogeco astrogeco added the enhancement New feature or request label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

General SCH_LAB cleanup jphickey/sch_lab
Ic 20200304 nasa/sch_lab
2 participants
@jphickey @astrogeco