Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #21, How to guide for setting up cmake for coverage-test #22

Closed
wants to merge 1 commit into from
Closed

Fix #21, How to guide for setting up cmake for coverage-test #22

wants to merge 1 commit into from

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Nov 19, 2019

Describe the contribution
How to guide for minimum needed to setup cmake for coverage-test

Testing performed
Steps taken to test the contribution:

  1. Create CMakeLists.
  2. cmake .
  3. make
  4. make test
  5. Test ran with assert successfully

Contributor Info
Anh Van, NASA Goddard

Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted

@skliper
Copy link
Contributor

skliper commented Jan 22, 2020

CCB 20200122 - The example in #26 likely covers it, but will review

@astrogeco astrogeco linked an issue Feb 6, 2020 that may be closed by this pull request
"How to" guide for setting up cmake for coverage test #21
Closed
@astrogeco astrogeco requested a review from jphickey February 6, 2020 17:33
@astrogeco astrogeco added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) CCB - 20200213 labels Feb 11, 2020
@astrogeco astrogeco added this to the 1.2.0 milestone Feb 12, 2020
@astrogeco astrogeco added CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. and removed CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Feb 13, 2020
@astrogeco astrogeco requested a review from a user February 19, 2020 15:58
@skliper
Copy link
Contributor

skliper commented Apr 8, 2020

@jphickey could you take a quick look at this one so we can get it out of the queue?

@jphickey
Copy link
Contributor

jphickey commented Apr 8, 2020

Sorry, did not realize this was still pending, thought it was withdrawn because the actual example should be the preferred reference.

@jphickey
Copy link
Contributor

jphickey commented Apr 8, 2020

Reviewing the commit within this pull request, the instructions are not accurate, so I would not recommend pulling this. I would rather simply refer to the example to illustrate the recommended practice

@skliper skliper closed this Apr 8, 2020
@skliper skliper added the duplicate This issue or pull request already exists label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey Awaiting requested review from jphickey

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

"How to" guide for setting up cmake for coverage test
4 participants
@avan989 @skliper @jphickey @astrogeco