fix #650 OS_chmod uses read or write access. #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
reviewed
Dec 1, 2020
4cd6531 to
0ecfba4
Compare
|
CCB 20201202 - APPROVED |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 7, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 9, 2020
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Rather than directly referencing a constant, prefer to use the sizeof() operator on the instance or type whenever possible.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Update use of uint32 to size_t in UT support code
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix all use of uint32 for sizes, replace with size_t Scrub all other types to make sure use is consistent, using proper typedef whenever available.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix all use of uint32 for sizes, replace with size_t Scrub all other types to make sure use is consistent, using proper typedef whenever available.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix all use of uint32 for sizes, replace with size_t Scrub all other types to make sure use is consistent, using proper typedef whenever available.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix all use of uint32 for sizes, replace with size_t Scrub all other types to make sure use is consistent, using proper typedef whenever available.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix all use of uint32 for sizes, replace with size_t Scrub all other types to make sure use is consistent, using proper typedef whenever available.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#663, more consistent use of data types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #650 by checking for either read or write access instead of just read access
Testing performed
Used the Chmod tests I am building in another branch that found this issue in the first place.
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
-No changes
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC