Fix #357: Make parameter const

[matzipan]

Describe the contribution
When OS_INCLUDE_MODULE_LOADER is not defined, the function header does not
match the definition. This issue was introduced in PR #21 .

Longer term: is there a continuous integration strategy to avoid this sort of situation happening in the future?

Testing performed
Build with module loader disabled with cFS master distribution.

Expected behavior changes
None

System(s) tested on

• PC, Ubuntu 19.04

Contributor Info
Andrei-Costin Zisu of Planetary Transportation Systems GmbH (Berlin, Germany). Company-wide CLA is in the process of being signed and should be available soon.

[skliper]

Good catch. We are definitely planning to enhance our CI to catch more issues like this. There are multiple opportunities for improvement (testing on multiple platforms, range of configuration settings, etc). As a start see the matrix in nasa/cFS#40.

Could you write a corresponding issue (and mark this pull as fixing it)? Our contribution guide is still in work, but the preference is that pull requests have an associated issue they are implementing/solving.

Also, if you can let me know when the CLA is sent (email preferred) it'll expedite the process.

Thanks for contributing!

[matzipan]

There are multiple opportunities for improvement (testing on multiple platforms, range of configuration settings, etc). As a start see the matrix in nasa/cFS#40.

We should discuss, we might lend a helping hand.

Could you write a corresponding issue (and mark this pull as fixing it)? Our contribution guide is still in work, but the preference is that pull requests have an associated issue they are implementing/solving.

Opened #357 .

Also, if you can let me know when the CLA is sent (email preferred) it'll expedite the process.

Will push for it and will let you know.

[skliper]

CCB 20200122 - Reviewed and approved for IC (pending CLA)

[skliper]

Status update - We have received a CLA for cFE (18.128), but not OSAL (see https://github.com/nasa/osal/blob/master/doc/GSC_18370_Corp_CLA_form_1219.pdf). Pull request pending receipt of OSAL CLA.

[stanislaw]

Status update - We have received a CLA for cFE (18.128), but not OSAL (see https://github.com/nasa/osal/blob/master/doc/GSC_18370_Corp_CLA_form_1219.pdf). Pull request pending receipt of OSAL CLA.

This is true. We have noticed that on our side already but a person who is supposed to sign the OSAL CCLA is not around for a few days. We will do it this week hopefully.

[stanislaw]

@skliper we have just signed the OSAL CCLA and sent it to to the GSFC-SoftwareRelease (Andrei Zisu and Stanislav Pankevich).

cc @matzipan

[skliper]

CLA for OSAL received, thanks!

[skliper]

@astrogeco Heads up this one is ready for merge to IC.