Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate cleanup code into a separate "FinalizeDelete" routine #564

Closed
jphickey opened this issue Aug 18, 2020 · 0 comments · Fixed by #567 or #576
Closed

Consolidate cleanup code into a separate "FinalizeDelete" routine #564

jphickey opened this issue Aug 18, 2020 · 0 comments · Fixed by #567 or #576
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
All OSAL objects share a basically common pattern for finalization after creation and deletion. For creation the finalization was consolidated into a OS_ObjectIdFinalizeNew routine, but the deletion finalization is basically repeated as it only involved clearing a single global.

Describe the solution you'd like
Even though deletion is currently trivial, it is beneficial to consolidate this code as it could become less trivial, as in issue #540

Additional context
This was split from #540

This is a necessary prerequisite in order to implement any sort of common/generic handling without repeating the code everywhere. It also makes deletion more of a mirror-image of creation, which is really the way it should be.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Aug 18, 2020
jphickey added a commit to jphickey/osal that referenced this issue Aug 18, 2020
@jphickey
Fix nasa#564, consolidate delete finalization code
6239c84 
Remove repetitive clearing of the global ID and unlocking
global table and replace with common implementation in the
idmap code.  In addition to removing repeated logic, this
makes deletion more like an inverse of creation, and provides
a common/single point where additiona deletion-related
logic can be added.
@jphickey jphickey mentioned this issue Aug 18, 2020
Merged
jphickey added a commit to jphickey/osal that referenced this issue Aug 18, 2020
@jphickey
Fix nasa#564, consolidate delete finalization code
2cc7dc5 
Remove repetitive clearing of the global ID and unlocking
global table and replace with common implementation in the
idmap code.  In addition to removing repeated logic, this
makes deletion more like an inverse of creation, and provides
a common/single point where additiona deletion-related
logic can be added.
yammajamma added a commit that referenced this issue Aug 20, 2020
@yammajamma
Merge pull request #567 from jphickey/fix-564-consolidate-delete
6d77666 
Fix #564, consolidate delete finalization code
yammajamma pushed a commit that referenced this issue Aug 20, 2020
@jphickey @yammajamma
Fix #564, consolidate delete finalization code
bbb0dff 
Remove repetitive clearing of the global ID and unlocking
global table and replace with common implementation in the
idmap code.  In addition to removing repeated logic, this
makes deletion more like an inverse of creation, and provides
a common/single point where additiona deletion-related
logic can be added.
@yammajamma yammajamma mentioned this issue Aug 24, 2020
Merged
@astrogeco astrogeco added this to the 6.0.0 milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @astrogeco