-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmony 1756 - Use trusted publisher token to publish to PyPi #41
Conversation
harmony/__init__.py
Outdated
@@ -7,7 +7,7 @@ | |||
""" | |||
|
|||
# Automatically updated by `make build` | |||
__version__ = "v1.0.26" | |||
__version__ = "1756beta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: shouldn't have checked in this change. The official release version here looks better than your test release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm - I don't recall doing that - maybe that got checked in by the build process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Jira Issue ID
HARMONY-1756
Description
Changes GitHub publish action to use trusted publisher token instead of password stored in GitHub secret.
Local Test Steps
harmony-service-lib
PR Acceptance Checklist