Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass master.bash file in CI #889

Merged
merged 148 commits into from
Aug 4, 2021
Merged

Bypass master.bash file in CI #889

merged 148 commits into from
Aug 4, 2021

Conversation

r9-pena
Copy link
Contributor

@r9-pena r9-pena commented Aug 3, 2021

Originating Project/Creator Ricardo Pena
Affected Component CI
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n) y
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Bypassed master.bash file to run test files directly.

Rationale

master.bash file was only used to run the correct test, which can be done directly from the job(s) arguments.

Future Work

Remove argument warning during the workflow

Copy link
Contributor

@Joshua-Anderson Joshua-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete the master.bash file while we're at it?

@Joshua-Anderson
Copy link
Contributor

make sure you set export CTEST_OUTPUT_ON_FAILURE=1 like master.bash does so that we get better CI error messages when unit tests fail.

Copy link
Contributor

@Joshua-Anderson Joshua-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LeStarch LeStarch merged commit 8fddb8c into nasa:devel Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants