In FprimeProtocol.cpp:deframe(), make buffer no larger than requested…

[nabcouwer]

Originating Project/Creator	JPL COLDArm / Neil Abcouwer
Affected Component	FramingProtocol
Affected Architectures(s)	n/a
Related Issue(s)	n/a
Has Unit Tests (y/n)	y (no change to unit tests for this change, but unit tests still run successfully)
Builds Without Errors (y/n)	y
Unit Tests Pass (y/n)	y
Documentation Included (y/n)	n

---

Change Description

When Svc/FramingProtocol/FprimeProtocol.cpp:deframe() calls m_interface->allocate(), set the size of the returned buffer to be the requested size.

Rationale

When Svc/FramingProtocol/FprimeProtocol.cpp:deframe() calls m_interface->allocate(), some allocators (StaticMemory) can return buffers that are larger than requested. In the case of uplink deframing, this size disparity makes it so commands can't be deframed successfully.

Alternatively, if returning a larger buffer than requested is bad, StaticMemory component could be changed instead. But should probably make allocation requests robust to bigger buffers due to alignment issues, etc.

Testing/Review Recommendations

Worked properly in our deployment with a deframer and static memory component, but wouldn't have an effect on Reference deployment.

Future Work

None

[LeStarch]

Good catch!