lestarch: fixing Fw::Time to allow comparisons across different time … #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metzdigital this should fix your issue too. |
You are my hero! |
bocchino
reviewed
Jun 30, 2021
|
@bocchino could you rereview? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bases
Change Description
Fw::Time doesn't assert when comparing across time bases, but returns INCOMPARABLE instead. This allows comparing against ZERO_TIME.
Rationale
Comparisons shouldn't crash the system. They should fail instead.
Future Work
Look into add and subtract methods. These are left for future work as it is less clear what to do in this case.