Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable additional LGTM queries #799

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Enable additional LGTM queries #799

merged 1 commit into from
Jun 30, 2021

Conversation

Joshua-Anderson
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Enables additional LGTM C++ static analysis queries to catch things like stack overflows, ignored check of null pointer after allocation, and dangerous string operations.

@Joshua-Anderson Joshua-Anderson requested a review from LeStarch June 29, 2021 23:40
LeStarch
LeStarch approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. If PRs start failing after this we'll need to support getting them up to this quality.

@LeStarch LeStarch merged commit 84bd254 into nasa:devel Jun 30, 2021
@Joshua-Anderson Joshua-Anderson deleted the enable-addtional-lgtm-queries branch June 30, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeStarch LeStarch LeStarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joshua-Anderson @LeStarch