-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default values for stuct members and scalar initialization of array members #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tested XmlEnumParser.py
…tested XmlEnumParser.py
Fetch upstream F' into serial default changes
Serial default
LeStarch
approved these changes
Jun 30, 2021
@bocchino want to review this too? |
bocchino
requested changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change request, otherwise looks good!
bocchino
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added support to allow a nested default element for struct members in F' XML. Autocoder initializes struct member to this
value in the constructor for the serializable. Also, allowed for initialization of arrays with a scalar value. This sets all elements in the array to the scalar value.
Rationale
These changes to the autocoder were made to support the FPP syntax and features.
Testing/Review Recommendations
Created new serialize4 test which tests autocoder functionality as it pertains to serializable objects.
All tests built and run with no issues.
Future Work
N/A