Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializable type for Enums #793

Merged
merged 19 commits into from
Jul 2, 2021
Merged

Serializable type for Enums #793

merged 19 commits into from
Jul 2, 2021

Conversation

rohandkn
Copy link
Contributor

Originating Project/Creator F Prime
Affected Component Autocoder
Affected Architectures(s) Enum
Related Issue(s)
Has Unit Tests (y/n) Y
Builds Without Errors (y/n) Y
Unit Tests Pass (y/n) Y
Documentation Included (y/n) Y

Change Description

Added infrastructure to allow a serialization type for enums. For each enum, the user can specify a type for which F Prime will use for serialization.

Rationale

FPP allows for a representation type. For this to be converted to XML, the autocoder needs to support it as well.

Testing/Review Recommendations

Modified the existing enum_xml tests to check that the serialization type is correctly set.

All tests built and run with no issues.

Future Work

N/A

@LeStarch LeStarch requested a review from bocchino June 30, 2021 15:58
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @bocchino do you want to look this over too?

Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LeStarch LeStarch merged commit 6fb9830 into nasa:devel Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants