Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assertion file name const #711

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

Joshua-Anderson
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Make assertion file name const

Rationale

Improve const correctness throughout F'

@Joshua-Anderson Joshua-Anderson requested a review from LeStarch June 15, 2021 01:04
@LeStarch LeStarch merged commit 1e4d08a into nasa:devel Jun 15, 2021
@timcanham
Copy link
Collaborator

timcanham commented Jun 15, 2021

Should it be const U8* const so that they can't change the pointer or the memory behind the pointer?

@LeStarch
Copy link
Collaborator

LeStarch commented Jun 15, 2021

@timcanham I had the same thought. However, I approved it because this ensures the memory is protected while still allowing the following (crude) algorithm if needed.

while (pointer != '\0') {
    putc(*pointrt);
    pointer++;
}

@Joshua-Anderson Joshua-Anderson deleted the assert-const-correctness branch June 15, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants