-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Unnecessary .gcov files #708
Conversation
Are there any files I missed that need deleting? |
@saba-ja does this work? |
Thank you for working on this task. ./Svc/PolyDb/test/ut/output/PolyDbImpl.hpp.gcov ./Svc/ActiveLogger/test/ut/output/ActiveLoggerComponentAc.cpp.gcov You can double check the result by running Note: Some of these gcov files are linked in the docs/sdd.md (see this for an example) If you like you can update the Unit Testing section of the sdd.md files by removing links to the gcov and test output file with the following statement: """ You can use the CmdDispatcher sdd as an example: To be organized make a separate commit after updating sdd.md of each component. Note: The maintainers might decide to keep some of the files depending on the group decision. |
Okay. Thank you for the feedback. I will remove the remaining files in the morning. If the maintainers agree with the files I have deleted, then this PR can be merged. Else I can recover those files. |
Is it okay if I just remove the entire output directory? Because thats what I've been doing until now |
Yes, you can remove the entire output directory. |
Ah ok, thanks. I'll get started when I come home from school (approx. 2:15 pm CET) |
@saba-ja Does that work? |
@AdvaitDhingra, SDD updates look good except for commit de60877 (Svc/Health/docs/sdd.md). |
Ah okay. I'll delete that commit with rebase -i and redo it. |
@AdvaitDhingra when you are finished with your proposed edits, let me know and I will rereview/merge this. |
Thank you. I think that's it. I fixed the mistake in SVC/Health/sdd.md so that should be it |
@AdvaitDhingra this is good. I will hold off merging just a bit as there are some other processes in-play. |
Change Description
Deleted all of the .gcov files in Svc, as the fprime-util tool renders theses useless.
Rationale
With the new fprime-util tool there is no need to keep the old executable files.
Testing/Review Recommendations
Tests all passed.
Future Work
Idk