Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused const qualifiers #701

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

Joshua-Anderson
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

These const qualifiers were unused, triggering GCC warnings when compiling with -Wextra.

@Joshua-Anderson Joshua-Anderson requested a review from LeStarch June 10, 2021 19:20
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will come back to us, but if it fixes issues today then we can merge it.

@Joshua-Anderson
Copy link
Contributor Author

This fixes warnings preventing us from enabling -Wextra. Let's merge it for now, adding it back in later if we add const to those functions should be easy (and the compiler will warn us).

@LeStarch LeStarch merged commit 5e818e1 into nasa:devel Jun 14, 2021
@Joshua-Anderson Joshua-Anderson deleted the remove-unused-const branch June 14, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants