Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lestarch: capturing all CI logs #688

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Jun 9, 2021

Originating Project/Creator Infra
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description and Rationale

Removed STATIC (unused) step in CI action such that the log files can be archived for review.

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

Misspellings found, please review:

  • czf
  • gz
To accept these changes, run the following commands from this repository on this branch
pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"Cyg "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"czf gz "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

@LeStarch LeStarch requested a review from Joshua-Anderson June 9, 2021 06:26
@jsoref
Copy link
Contributor

jsoref commented Jun 9, 2021

for czf, add this to patterns.txt:

# tar arguments
\b(?:\\n|)tar(?:\s+-[a-zA-Z]+|\s[a-z]+)+

from: https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns

And, for the other, I need to send an upgrade PR, since the latest version moves the minimum word length from 2 to 3 by default (two letter typos just aren't worth checking).

@LeStarch LeStarch requested a review from saba-ja June 9, 2021 15:17
Copy link
Contributor

@Joshua-Anderson Joshua-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to access these logs after a CI run?

@LeStarch
Copy link
Collaborator Author

LeStarch commented Jun 9, 2021

They are attached to the workflow. Selection Actions and CI or click on Details above (once the run is finished) and there is an artifacts pane at the bottom of the screen

@LeStarch LeStarch merged commit 401a9a7 into nasa:devel Jun 9, 2021
@LeStarch LeStarch deleted the update/fix-gcda branch September 2, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants