Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dup to fcntl #3047

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Dup to fcntl #3047

merged 3 commits into from
Nov 25, 2024

Conversation

kevin-f-ortega
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Change dup to fcntl. How fcntl is used here, it should be equivalent to dup.

Rationale

Needed for VxWorks when compiling with Posix File.

Testing/Review Recommendations

CI

Future Work

Note any additional work that will be done relating to this issue.

@kevin-f-ortega kevin-f-ortega self-assigned this Nov 25, 2024
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I appreciate this fix!

Os/Posix/File.cpp Dismissed Show dismissed Hide dismissed
@LeStarch
Copy link
Collaborator

Markdown link fixed elsewhere.

@LeStarch LeStarch merged commit b40097e into devel Nov 25, 2024
35 of 36 checks passed
@kevin-f-ortega kevin-f-ortega deleted the dup-to-fcntl branch November 25, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants