Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved Drv ports to a Ports directory #3008

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

kevin-f-ortega
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Moving ports in fprime/Drv to fprime/Drv/Ports

Rationale

Having a Ports directory for ports is inline with how F Prime structures its directories

Testing/Review Recommendations

Run through CI

Future Work

Note any additional work that will be done relating to this issue.

…inline with how F Prime structures its directories
@kevin-f-ortega kevin-f-ortega self-assigned this Nov 4, 2024
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Are you going to merge the port directories?
  2. Can we move Drv_DataTypes into the Ref App, as it is only used by sample components and has no business outside of that App.

@kevin-f-ortega
Copy link
Collaborator Author

@LeStarch,

I merged the port directories.

Drv_DataTypes is being used by Drv.BlockDriver; so, I cannot move DataTypes outside of Drv. I went ahead and added the DataTypes directory into the Ports directory.

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I understand. We need a better replacement for BlockDriver.....but it is not available today.

@LeStarch LeStarch merged commit c34482d into nasa:devel Nov 18, 2024
67 of 68 checks passed
@kevin-f-ortega kevin-f-ortega deleted the move-ports-to-dir branch November 18, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants