Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Command Interface #2753

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Create Command Interface #2753

merged 4 commits into from
Jun 3, 2024

Conversation

rmzmrnn
Copy link
Contributor

@rmzmrnn rmzmrnn commented May 29, 2024

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Pulls Command ports into an interface.

  • Created Fw/Interfaces/CommandInterface.fppi which contains the Command ports
  • Removed the Command ports from Ref/SignalGen/SignalGen.fpp, replacing it with the interface

Rationale

Resolves Create Command Interface #2586

Testing/Review Recommendations

N/A

Future Work

N/A

LeStarch
LeStarch approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct!

@LeStarch LeStarch merged commit db10ade into nasa:devel Jun 3, 2024
34 checks passed
@rmzmrnn rmzmrnn deleted the issue-2586 branch June 4, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeStarch LeStarch LeStarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Command Interface
2 participants
@rmzmrnn @LeStarch