Update demo to show member array support gds #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
approved these changes
Feb 6, 2024
Ref/TypeDemo/TypeDemo.fpp
Outdated
| @@ -31,6 +31,8 @@ module Ref { | |||
| separateChoice: Choice | |||
| @ A pair of choices | |||
| choicePair: ChoicePair | |||
| @ An array of choices defined as member array | |||
| choiceAsMemberArray: [2] U8 | |||
There was a problem hiding this comment.
Switch the 2 to dimension if you will. It makes it easier to modify all the array sizes.
There was a problem hiding this comment.
I apply your suggestion. Please note that before merging this, the related pull request in fprime-gds should be merged otherwise fprime-gds will not work as expected with the new member array.
…b.com/SMorettini/fprime into UpdateDemoToShowArrMemberaySupportGds
thomas-bc
approved these changes
Feb 7, 2024
LeStarch
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description