Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize UT of RateGroupDriver #2472

Merged

Conversation

SMorettini
Copy link
Contributor

Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

The UT of RateGroupDriver was failing if RateGroupDriverRateGroupPorts in AcConstant.fpp was different from 3. The new change makes the test work for any value.

@LeStarch
Copy link
Collaborator

LeStarch commented Jan 8, 2024

I switched the use of int (signed) to the used of FwIndexType that is the expected type to represent such things (i.e. port indices). Hope you don't mind the assistance, figured it was easier than the back-and-forth for such a small delta. Thanks for this correction, it will help substantially!

@SMorettini
Copy link
Contributor Author

SMorettini commented Jan 10, 2024

@LeStarch thanks for the fix. It still doesn't pass the CI, I wanted to solve it but I don't know if you prefer casting the DIVIDER_SIZE or change the type of i

@LeStarch
Copy link
Collaborator

@SMorettini in this case, I'd cast it.

@SMorettini SMorettini requested a review from LeStarch January 11, 2024 08:00
@LeStarch LeStarch merged commit 05ff444 into nasa:devel Jan 11, 2024
34 checks passed
@SMorettini SMorettini deleted the Make-RateGroupDriver-Test-More-General branch January 12, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants