CMake Implementation Selection #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cacc5b to
7c48a74
Compare
thomas-bc
approved these changes
Nov 28, 2023
|
Fixed! |
thomas-bc
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This adds in the CMake functionality to allow choices of various implementation sets backed by CMake. The canonical example is choosing task implementations for the OS layer.
These changes were previously reviewed here: #2121
I've decided that a long-running feature branch is not the way to go due to the difficulty of keeping up with
nasa/devel. It is better to refactor individual OSAL units one at a time, leaving the others.Rationale
Keeping up with nasa/devel is challenging. Better to reduce the PR to unit-steps.
Testing/Review Recommendations
Ensure stock builds work.
Future Work
Refactoring each OSAL subunit one at a time.