Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing join after task failed creation. Fixes #1955 #2367

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Removing join after task failed creation. Fixes #1955 #2367

merged 1 commit into from
Nov 13, 2023

Conversation

LeStarch
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

When pthread_create fails, the contents of *thread is undefined, however; we erroneously pass it to a pthread_join after a failure. This removes that erroneous line.

@LeStarch
Copy link
Collaborator Author

Fixes #1955

timcanham
timcanham approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@timcanham timcanham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeStarch LeStarch merged commit 4277591 into nasa:devel Nov 13, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-bc thomas-bc thomas-bc approved these changes

@timcanham timcanham timcanham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeStarch @timcanham @thomas-bc