-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor locs, dependencies into generic sub build #2360
Conversation
f6b39bb
to
b4e67e9
Compare
Note: although structurally much nicer, this slows down the initial generate time. Here are some numbers:
Notice that the re-generation (changed a model/CMakeLists.txt) is substantially faster. |
96a1eda
to
5712017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits/comments, but overall looks good to me!
8134c07
to
5ed3f38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Change Description
Creates generic sub-builds and makes locs/dependencies into a sub-build. This replaces the hardcoded prescan function.
Rationale
Sub-builds are a standard pattern in CMake and this exposes this functionality in a generic form to users. Reworking pre-scan into this has the following advantages:
-j
will work for sub/builds and fpp-depend isn't mapped to the whole CPU.Future Work
Note any additional work that will be done relating to this issue.
Review fixes tracked as check-list: