Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Svc.Time into An Interface #2317

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Convert Svc.Time into An Interface #2317

merged 5 commits into from
Oct 25, 2023

Conversation

LeStarch
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Fixes #2256

@LeStarch LeStarch requested a review from thomas-bc October 13, 2023 03:44
@LeStarch LeStarch added the Update Instructions Needed Need to add instructions in the release notes for updates. label Oct 13, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 13, 2023
View reviewed changes
Svc/PosixTime/PosixTime.hpp Fixed Show fixed Hide fixed
Svc/PosixTime/test/ut/PosixTimeTester.hpp Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 13, 2023
View reviewed changes
Svc/PosixTime/PosixTime.cpp Dismissed Show dismissed Hide dismissed
thomas-bc
thomas-bc reviewed Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@thomas-bc thomas-bc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor comment

Svc/Interfaces/Time.fppi Show resolved Hide resolved
@LeStarch
Copy link
Collaborator Author

Merge it merge it!

@LeStarch LeStarch merged commit b5777e9 into nasa:devel Oct 25, 2023
31 checks passed
This was referenced Oct 25, 2023
Merged
Merged
Merged
@thomas-bc thomas-bc mentioned this pull request Nov 28, 2023
Merged
@amalnathh amalnathh mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-bc thomas-bc thomas-bc approved these changes

Assignees
No one assigned
Labels
Update Instructions Needed Need to add instructions in the release notes for updates.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Svc::Time Interface
2 participants
@LeStarch @thomas-bc